This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
DEV-1367: Image size problems #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gondragos
commented
Dec 27, 2021
Gondragos
commented
- fix the calculation of the stage size on the window resizing at a given image width
- add frame to crop the image to the stage size
- add height and maxheight params
- set max width as 100% by default
# Conflicts: # src/components/ImageView/ImageView.js # src/tags/object/Image.js
hlomzik
approved these changes
Dec 28, 2021
# Conflicts: # e2e/fragments/ErrorsCollector.js
- set heuristic maxHeight default value - add comment - remove unused volatile - remove duplicate functionality
Solved by preventing preserving selected tool
hlomzik
approved these changes
Jan 19, 2022
# Conflicts: # src/components/ImageView/ImageView.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.